Jump to content
Arthmoor

[RELz/WIPz] Unofficial Skyrim Special Edition Patch

Recommended Posts

On 5/9/2020 at 1:37 PM, Arthmoor said:

The fix for 19338 was moved to the retro script for 4.2.3 instead of UDBP 2.1.2 to correct that it wasn't setting the right levels and amounts.

Aha, might help to be mentioned in USSEP Fixes, with the usual strikeout in UDBP. I know most folks never read it, but a few of us do.... ;)

Share this post


Link to post
Share on other sites
54 minutes ago, DayDreamer said:

The problem at the moment is no way to decide whether the vanilla driver is sitting in his carriage seat. ICAIO moves the driver around, and has him sleeping. The long-time US*P solution is checking that he's sitting anywhere, fixing a lot of grief, but there are cases of that not being quite correct (sitting inside, sitting on a bench outside). Still, it's much better than nothing!

What I'm currently doing in Touring Carriages is after the player selects "Where do you want to go?" checking bSitting. Unfortunately, because that test happens afterward, the player sees only "Never mind."

I was looking for a definitive early test (such as the aforementioned "link.IsInFurnitureState Sit == 1 AND"; that works in scripting). Apparently, even though documented, it doesn't work properly in conditions. Or I'm doing it wrong.

 

You probably have to track this for each driver and store the tracking variable. OnActivate() events on the carriages should reliably work to tell you whether the driver is sitting (and in which carriage). OnSit() is not reliable and may even pass a wrong furniture ref (apparently an engine bug, according to the notes on the CK Wiki). OnGetUp(), on the other hand, is reliable,

Share this post


Link to post
Share on other sites
8 hours ago, Sclerocephalus said:

OnSit() is not reliable and may even pass a wrong furniture ref (apparently an engine bug, according to the notes on the CK Wiki).

Interesting. That's a vanilla script: CarriageDriverScript. The Bug note is 2015. Anybody know whether that bug has been formally reported to Bethesda?

The bSitting conditional variable is only relied upon in one line of code. Since the vanilla driver only ever sits in one place, this bug may not have occurred in the past.

ICAIO claims (on its description) to have been QA'd by Bethesda. Arthmoor's target practice is on the same Bethesda page, so he could tell us how much vetting is actually done....

What should be done for US*P?

Share this post


Link to post
Share on other sites

I would take any claims of being "QA'd" by Bethesda with a grain of salt. As far as I know the only testing they do is enough to make sure it loads. Maybe they do more than that, but they never told me what that was. I seriously doubt they'd have spent any serious time running a much more complex mod like ICAO through any sort of formal testing.

As far as USSEP is concerned, there's no bug because the carriage drivers never stay off the carts for very long if you manage to be able to dislodge them in a vanilla setup. They certainly don't go running off to hide in a building or whatever, even if you attack them directly. The only thing we did for the dialogue itself was to make sure you couldn't initiate a cart ride while he was out of his seat, and so far I've seen no indication that this is broken unless ICAO is installed.

Share this post


Link to post
Share on other sites
On 5/11/2020 at 3:11 PM, Arthmoor said:

They certainly don't go running off to hide in a building or whatever,

IIRC, we added that condition because of Run For Your Lives; actually When Vampires Attack at the time, driver ran and hid in Windhelm City, and trying to take a ride from him caused a reproducible problem. Ensuring he was sitting was enough to fix it, because the only place he sat was on his linked seat.

On 5/11/2020 at 3:11 PM, Arthmoor said:

so far I've seen no indication that this is broken unless ICAO is installed.

Agreed. Personally, I don't run ICAIO (I've always used Run For Your Lives), so I've no good reproducible tests. It's just user reports. (Many of them.)

Thanks for all the assistance. At least I've learned something about failures of the OnSit() event and the "link.IsInFurnitureState Sit" conditional. Maybe they'll work in some future game engine.

Reported bugs in tickets 200515-007256 and 200515-07347 respectively. No idea how to access anybody else's tracked bugs.

Share this post


Link to post
Share on other sites

That may have been the case with really old copies of RFYL or WVA, but that issue with the carriage drivers was fixed long ago before SSE was even a thing. So nobody playing on SSE should be having any trouble with those drivers today because their faction is exempt from consideration as one of the aliases to fill. So unless they're directly attacked they'll sit on that carriage ignoring the world around them. Unrealistic? Indeed, but better than them running off somewhere and never coming back.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Support us on Patreon!

Patreon
×
×
  • Create New...